> +   private final int statusId;
> +   private final String mountType;
> +   private final String mountMode;
> +   private final int bootableFlag;
> +   private final String device;
> +   private final VirtualDiskImage virtualDiskImage;
> +   private final VirtualGuest guest;
> +
> +   @ConstructorProperties({
> +           "id", "uuid", "statusId", "mountType", "mountMode", 
> "bootableFlag", "device", "diskImage", "guest"
> +   })
> +   protected VirtualGuestBlockDevice(int id, String uuid, int statusId, 
> String mountType, String mountMode,
> +                                     int bootableFlag, String device, 
> VirtualDiskImage virtualDiskImage,
> +                                     VirtualGuest guest) {
> +      this.id = id;
> +      this.uuid = uuid;

Add a null check for all required parameters, or mark them as `@Nullable`.

Also annotate each class member variable which name does not match the 
serialized representation with: `@Named("serialized_name")`. This way, the 
`@ConstructorProperties` tells jclouds how to deserialize the object, and the 
`@Named` annotations will tell how to serialize, if needed (whether domain 
objects might not be directly serialized, annotations should be consistent).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r10452016

Reply via email to