> +   @Consumes(MediaType.APPLICATION_JSON)
> +   @Headers(keys = "Content-Type", values = "application/tar")
> +   InputStream build(@QueryParam("t") String tag, Payload inputStream);
> +
> +   /**
> +    * Build an image from Dockerfile via stdin
> +    */
> +   @Named("image:build")
> +   @POST
> +   @Path("/build")
> +   @Consumes(MediaType.APPLICATION_JSON)
> +   @Headers(keys = "Content-Type", values = "application/tar")
> +   InputStream build(@QueryParam("t") String tag, @QueryParam("q") boolean 
> quiet, @QueryParam("nocache") boolean nocache,
> +                     @BinderParam(BindInputStreamToRequest.class) File 
> dockerFile);
> +
> +}

Some general considerations on the api class:

* Add the javadoc for all method parameters.
* For those parameters that are optional, better have two method: one that 
doesn't have them, and another one that encapsulates all them in an Options 
object, so users don't have to call a method with lots of `null` parameters.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/57/files#r10839625

Reply via email to