> @@ -102,6 +103,27 @@ public String toString() {
>  
>     }
>  
> +   public static class BlockDevice{
> +      @Named("volume_size")
> +      String volumeSize = "";
> +      @Named("volume_id")
> +      String volumeId;
> +      @Named("delete_on_termination")
> +      int deleteOnTermination = 0;
> +      @Named("device_name")
> +      String deviceName;
> +
> +      public BlockDevice(String volumeId, String deviceName){
> +         this(volumeId, deviceName, true);
> +      }
> +
> +      public BlockDevice(String volumeId, String deviceName, boolean 
> deleteWhenInstanceTerminated){

We don't typically expose ctors like here and above directly. These should be 
factory methods.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326/files#r10999095

Reply via email to