> + for (int i = 0; i < blockDeviceCapacities.size(); i++) {
> + if (i > 0) { devicePosition = i + 1; }
> + blockDevices.add(VirtualGuestBlockDevice.builder()
> + .device(devicePosition + "")
> + .diskImage(VirtualDiskImage.builder()
> + .capacity(blockDeviceCapacities.get(i))
> + .typeId(Type.valueOf(diskType).ordinal())
> + .build())
> + .build());
> + }
> + return blockDevices;
> + }
> +
> + private Optional<OperatingSystem> tryGetOperatingSystemFrom(final String
> imageId) {
> + Set<OperatingSystem> operatingSystemsAvailable =
> createObjectOptionsSupplier.get().getVirtualGuestOperatingSystems();
> + return tryFind(from(operatingSystemsAvailable)
I'm in favor of static imports, but when they improve readability. In the case
of `from`, when statically imported it's harder to understand what's happening:
From `operatingSystemsAvailable ` to what? In this cases I tend to avoid using
static imports in favor of a more readable code.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11137710
