Thanks @ashley-taylor! A couple comments:

* The name of the property seems too generic (one reading it might not 
understand where it applies). Could you rename it so it reflects better it 
applies to socket testing?
* Could it be interesting to also allow to exclude the private ones too? 
Perhaps having an enum "SocketTesting" with "public", "private" and "all" 
options could lead to more flexible/complete configuration.
* All changes **must** include the corresponding unit tests in the 
ConcurrentOpenSocketFinderTest class.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/341#issuecomment-39933486

Reply via email to