> @@ -175,10 +179,17 @@ public String toString() {
> };
> }
>
> - private static FluentIterable<String> checkNodeHasIps(NodeMetadata node) {
> - FluentIterable<String> ips =
> FluentIterable.from(concat(node.getPublicAddresses(),
> node.getPrivateAddresses()));
> - checkState(size(ips) > 0, "node does not have IP addresses configured:
> " + node);
> - return ips;
> + private static FluentIterable<String> checkNodeHasIps(NodeMetadata node,
> AllowedInterfaces allowedInterfaces) {
> + ImmutableSet.Builder<String> ipsBuilder = ImmutableSet.builder();
> + if (allowedInterfaces.scanPublic) {
> + ipsBuilder.addAll(node.getPublicAddresses());
> + }
> + if (allowedInterfaces.scanPrivate) {
> + ipsBuilder.addAll(node.getPrivateAddresses());
> + }
> + ImmutableSet<String> ips = ipsBuilder.build();
> + checkState(!ips.isEmpty(), "node does not have IP addresses
> configured: " + node);
[minor] Prefer the form:
```java
checkState(!ips.isEmpty(), "node does not have IP addresses configured: %s",
node);
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/341/files#r11473174
