> + > + /** > + * Get SPICE Console > + * @param serverId Server id > + * @param type Only "spice-html5" is supported > + * @return a Console object containing the console url and type. > + */ > + Console getSPICEConsole(String serverId, Console.Type type); > + > + /** > + * Get RDP Console > + * @param serverId Server id > + * @param type Only "rdp-html5" is supported > + * @return a Console object containing the console url and type. > + */ > + Console getRDPConsole(String serverId, Console.Type type);
Hm...if each of these methods only accepts _some_ of the values of the `Type` enum, would it make sense to have three enums? In fast, since SPICE and RDP only support one valid value _anyway_, how about just using the enum for getVNCConsole? And unless we expect the number of options to grow rapidly, would two methods `getNoVNCConsole` and `getXvpVNCConsole` (not sure about the correct capitalization here) be easier for users to work with? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/339/files#r11597880
