> I guess we should also have a JIRA issue and a unit test for this?

I've just opened 
[JCLOUDS-543](https://issues.apache.org/jira/browse/JCLOUDS-543) to track this.

There is no unit test class for the `DropletToNodeMetadata` class. @cobbzilla, 
mind creating the `DropletToNodeMetadataTest` class and add a unit test that 
validates your change? We use `EasyMock` for this kind of unit tests. If you 
need some reference, you can take a look at how the 
[EC2](https://github.com/jclouds/jclouds/blob/master/apis/ec2/src/test/java/org/jclouds/ec2/compute/functions/RunningInstanceToNodeMetadataTest.java)
 or 
[Abiquo](https://github.com/jclouds/jclouds-labs/tree/master/abiquo/src/test/java/org/jclouds/abiquo/compute/functions)
 tests work. There's no need to add a complete test for all cases in this PR, 
just add one to validate your changes. Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/58#issuecomment-41133688

Reply via email to