A couple comments: * When you transform an existing instance to a `NodeMetadata` object, you force a non-null hardware: https://github.com/andreaturli/jclouds-labs-google/blob/fix/machineType-obsolete/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/InstanceInZoneToNodeMetadata.java#L101-L102 This conflicts with your change to the `listHardwareProfiles` method and will throw NPEs if old nodes created with deprecated machine types exist in the provider. * A test should be added in the `GoogleComputeEngineServiceLiveTest` that verifies that the `listHardwareProfiles` method does not return obsolete hardwares.
--- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/24#issuecomment-41394473
