> + // setup expectations > + expect(options.getGroupIds()).andReturn(ImmutableSet.<String> of()); > + expect(options.getGroups()).andReturn(groupNames).atLeastOnce(); > + expect(options.getInboundPorts()).andReturn(ports).atLeastOnce(); > + RegionNameAndIngressRules regionNameAndIngressRules = new > RegionNameAndIngressRules(region, generatedMarkerGroup, > + ports, shouldAuthorizeSelf); > + > expect(strategy.securityGroupMap.getUnchecked(regionNameAndIngressRules)).andReturn(generatedMarkerGroup); > + > + // replay mocks > + replay(options); > + replayStrategy(strategy); > + > + // run > + > + RunInstancesOptions customize = strategy.execute(region, group, > template); > + assertEquals(strategy.addSecurityGroups(region, group, template, > customize), returnVal);
Hi Andrew, I have mistakenly committed an half baked change. Will fix asap. Thanks. Sent from my mobile. On May 1, 2014 5:42 AM, "Andrew Phillips" <[email protected]> wrote: > In > providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/strategy/CreateKeyPairPlacementAndSecurityGroupsAsNeededAndReturnRunOptionsTest.java: > > > + // setup expectations > > + expect(options.getGroupIds()).andReturn(ImmutableSet.<String> of()); > > + expect(options.getGroups()).andReturn(groupNames).atLeastOnce(); > > + expect(options.getInboundPorts()).andReturn(ports).atLeastOnce(); > > + RegionNameAndIngressRules regionNameAndIngressRules = new > > RegionNameAndIngressRules(region, generatedMarkerGroup, > > + ports, shouldAuthorizeSelf); > > + > > expect(strategy.securityGroupMap.getUnchecked(regionNameAndIngressRules)).andReturn(generatedMarkerGroup); > > + > > + // replay mocks > > + replay(options); > > + replayStrategy(strategy); > > + > > + // run > > + > > + RunInstancesOptions customize = strategy.execute(region, group, > > template); > > + assertEquals(strategy.addSecurityGroups(region, group, template, > > customize), returnVal); > > Looks like this is causing the compilation failure? addSecurityGroupsreturns > void. > > — > Reply to this email directly or view it on > GitHub<https://github.com/jclouds/jclouds/pull/333/files#r12172928> > . > --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/333/files#r12173604
