> + expect(backoffHandler.shouldRetryRequest(command, > response)).andReturn(true).once(); > + expect(response.getStatusCode()).andReturn(408).once(); > + > + replay(command); > + replay(response); > + replay(cache); > + replay(backoffHandler); > + > + RetryOnRenew retry = new RetryOnRenew(cache, backoffHandler); > + > + assertTrue(retry.shouldRetryRequest(command, response)); > + > + verify(command); > + verify(response); > + verify(cache); > + verify(backoffHandler);
Do we need the verify calls here, i.e. do we care about how exactly the mocks are called? Or do we just need them to provide data if called? If we feel we need them, write as `verify(command, response, cache, backoffHandler)`? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/369/files#r12774730
