Use slugs as IDs and assume a node can have a `null` image if it used an imageId that has been removed.
With this change the objects in the portable model will have the "slug" in the ID field and the real ID in the "providerId" field. Private images, which don't have a slug, will also have the real ID populated in the ID field. This will allow users to use the ComputeService using the slugs, which won't change, to search for images using portable code. This pull request supercedes https://github.com/jclouds/jclouds-labs/pull/58 to properly use the new slug fields provided by the provider api. You can merge this Pull Request by running: git pull https://github.com/nacx/jclouds-labs slug-ids Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/63 -- Commit Summary -- * JCLOUDS-543/JCLOUDS-572: Use slugs as IDs and assume a node can have a null image if it used an imageId that has been removed -- File Changes -- M digitalocean/pom.xml (2) M digitalocean/src/main/java/org/jclouds/digitalocean/compute/extensions/DigitalOceanImageExtension.java (10) M digitalocean/src/main/java/org/jclouds/digitalocean/compute/functions/DropletToNodeMetadata.java (61) M digitalocean/src/main/java/org/jclouds/digitalocean/compute/functions/ImageToImage.java (4) M digitalocean/src/main/java/org/jclouds/digitalocean/compute/functions/SizeToHardware.java (3) M digitalocean/src/main/java/org/jclouds/digitalocean/compute/strategy/DigitalOceanComputeServiceAdapter.java (6) M digitalocean/src/main/java/org/jclouds/digitalocean/domain/Size.java (7) M digitalocean/src/main/java/org/jclouds/digitalocean/features/DropletApi.java (36) M digitalocean/src/main/java/org/jclouds/digitalocean/features/ImageApi.java (44) M digitalocean/src/test/java/org/jclouds/digitalocean/compute/functions/DropletToNodeMetadataTest.java (29) M digitalocean/src/test/java/org/jclouds/digitalocean/compute/functions/ImageToImageTest.java (5) M digitalocean/src/test/java/org/jclouds/digitalocean/compute/functions/SizeToHardwareTest.java (5) M digitalocean/src/test/java/org/jclouds/digitalocean/features/DropletApiLiveTest.java (20) M digitalocean/src/test/java/org/jclouds/digitalocean/features/DropletApiMockTest.java (52) M digitalocean/src/test/java/org/jclouds/digitalocean/features/ImageApiLiveTest.java (36) M digitalocean/src/test/java/org/jclouds/digitalocean/features/ImageApiMockTest.java (54) M digitalocean/src/test/resources/image1.json (2) M digitalocean/src/test/resources/image2.json (2) M digitalocean/src/test/resources/images.json (4) M digitalocean/src/test/resources/sizes.json (8) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/63.patch https://github.com/jclouds/jclouds-labs/pull/63.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/63
