I've addressed the comments and added a couple improvements: * Extracted the region id+name encoding logic into a `LocationNamingUtils` class, to avoid exposing it in many places. * Removed an unnecessary call to the provider in the `ComputeServiceAdapter` to get the details of the location, and used the cached locations instead.
All live tests are passing. ```bash Tests run: 56, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 34:48 min (Wall Clock) [INFO] Finished at: 2014-05-20T12:52:41+01:00 [INFO] Final Memory: 29M/618M [INFO] ------------------------------------------------------------------------ ``` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/63#issuecomment-43611387
