> +    */
> +   @Named("DescribeVault")
> +   @GET
> +   @Path("/-/vaults/{vault}")
> +   @ResponseParser(ParseVaultMetadataFromHttpContent.class)
> +   ListenableFuture<VaultMetadata> describeVault(
> +         @PathParam("vault") @ParamValidators(VaultNameValidator.class) 
> String vaultName);
> +
> +   /**
> +    * @see GlacierClient#listVaults
> +    */
> +   @Named("ListVaults")
> +   @GET
> +   @Path("/-/vaults")
> +   @ResponseParser(ParseVaultMetadataListFromHttpContent.class)
> +   ListenableFuture<PaginatedVaultCollection> 
> listVaults(PaginationOptions... options);

In general we don't want to use vararg parameters to express that a parameter 
is optional. It wouldn't make sense to pass more than one `PaginationOptions` 
instance to this method, but the interface allows it (and jclouds will fail at 
runtime when generating the request).

Instead of using the varargs, just overload the method. Use a method that takes 
no arguments, and a method that takes just one.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/4/files#r12842730

Reply via email to