Hi @andreaturli. Many thanks for this PR! It is a long one and there is much work behind it. Thanks! I've done a last review, and I think there are no major things to change. The following (and I hope the last steps) should be:
- **General** - [ ] Check all existing review comments (the ones I've added and the ones that were already there from previous reviews) and address or comment on them. - **Domain model** - [ ] Remove the null checks for primitive parameters - [ ] Remove the abstract/concrete builder pattern and use just a Builder object. - **Api classes** - [ ] Move all `@Consumes` annotations at class level. - **UnitTests** - [ ] Add tests for the `TagToJson` binder. - [ ] Add tests for the `OperatingSystems` class. - [ ] Remove all `System.out` in the `SoftLayerComputeServiceContextLiveTest` class. There are many tests in this provider, and that is very much appreciated. Thanks for your hard work on this! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/296#issuecomment-43719145
