> +      }, null);
> +   }
> +
> +   @Override
> +   public Iterable<Container> listNodes() {
> +      Set<Container> containers = Sets.newHashSet();
> +      for (Container container : api.getRemoteApi().listContainers()) {
> +         // less efficient than just listNodes but returns richer json
> +         
> containers.add(api.getRemoteApi().inspectContainer(container.getId()));
> +      }
> +      return containers;
> +   }
> +
> +   @Override
> +   public Iterable<Container> listNodesByIds(final Iterable<String> ids) {
> +      return filter(listNodes(), new Predicate<Container>() {

This will generate a call to inspect *every* container, when you're only asking 
for a subset. Remove this and directly call `inspectContainer` on the provided 
ids.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/57/files#r12937268

Reply via email to