> + }
> +
> + private String extractOsVersion(OsFamily family, String name) {
> + String version = null;
> + if (family == OsFamily.WINDOWS) {
> + // TODO: Find a way to restrict better the windows version
> + Matcher matcher = WINDOWS_VERSION_PATTERN.matcher(name);
> + if (matcher.matches()) {
> + version = matcher.group(1);
> + }
> + } else {
> + Matcher matcher = UNIX_VERSION_PATTERN.matcher(name);
> + if (matcher.matches()) {
> + version = matcher.group(1);
> + }
> + }
Something like
```
Pattern versionPattern = (family == OsFamily.WINDOWS) ? WINDOWS_VERSION_PATTERN
: UNIX_VERSION_PATTERN;
Matcher matcher = versionPattern.matcher(name);
if (matcher.matches()) {
version = matcher.group(1);
}
...
```
?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/362/files#r13033789
