> +    @Test
> +    public void testGetVNCConsole() {
> +        for (String zoneId : api.getConfiguredZones()) {
> +            Optional<? extends ConsolesApi> apiOption = 
> api.getConsolesExtensionForZone(zoneId);
> +            if (!apiOption.isPresent())
> +                continue;
> +
> +            ConsolesApi api = apiOption.get();
> +            ServerApi serverApi = this.api.getServerApiForZone(zoneId);
> +            Server server = createServerInZone(zoneId);
> +            Console console = api.getConsole(server.getId(), 
> Console.Type.NOVNC);
> +            assertNotNull(console);
> +            assertNotNull(console.getType());
> +            assertTrue(Console.Type.NOVNC.equals(console.getType()));
> +            assertNotNull(console.getUrl());
> +            assertTrue(console.getUrl().toString().startsWith("http"));

Why can we expect this? Is this likely to be brittle? What if this where a 
different (non-empty) value...would that mean the server was broken? Or our 
parsing logic?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/339/files#r13035073

Reply via email to