> +
> +      Console.Type type = (Console.Type) postParams.get("type");
> +
> +      switch (type) {
> +         case NOVNC:
> +         case XVPVNC:
> +            action = "os-getVNCConsole";
> +            break;
> +         case SPICE_HTML5:
> +            action = "os-getSPICEConsole";
> +            break;
> +         case RDP_HTML5:
> +            action = "os-getRDPConsole";
> +            break;
> +         default:
> +            throw new IllegalArgumentException("Invalid type: " + type);

> if the someone pass a null value as the type argument of getConsole() function

See comment below. Is `null` a valid input to `getConsole`? If not, we should 
be throwing an error long before we get here, I'd say?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/339/files#r13058923

Reply via email to