>           String eTag = 
> base16().lowerCase().encode(payload.getContentMetadata().getContentMD5());
>           return eTag;
>        } catch (IOException ex) {
> +         Closeables.closeQuietly(his);

In the `catch` or the `finally`? Or is the stream correctly closed somewhere 
else? The [Javadoc from 
`writeFrom`](http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/io/ByteSink.html#writeFrom(java.io.InputStream\))
 says, if I'm looking at the correct method: "Writes all the bytes from the 
given InputStream to this sink. Does not close input."

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/379/files#r13061753

Reply via email to