> @@ -84,8 +85,12 @@ protected Properties setupProperties() {
>     }
>     
>     protected Server createServerInZone(String zoneId) {
> +      return createServerInZone(zoneId, null);

Use `new CreateServerOptions()` instead of `null` here, or have a (nasty?) 
if...then below that does something like
```
if (options != null) {
  ServerCreated server = serverApi.create(hostName, imageIdForZone(zoneId), 
flavorRefForZone(zoneId), options);
} else {
  ServerCreated server = serverApi.create(hostName, imageIdForZone(zoneId), 
flavorRefForZone(zoneId));
}
```
?

It's [not 
marked](https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/features/ServerApi.java#L84)
 as `@Nullable`, so I think we'd be safer not passing `null` here.

@jdaggett @zack-shoylev @everett-toews Please correct me if that's not right!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/392/files#r13737467

Reply via email to