Many thanks for addressing the licensing thing, @igreenfield. Just one last
comment.
Apache releases must include the NOTICE file in the top level directory. The
build process auto-generates the file if it does not exist, but it does not
"compose" it based on the NOTICE files found in the project subfolders. In
order to make your copyright appear in the right place when the project is
built, the NOTICE file you added should be moved to the root of the repo. Could
you do that?
You'll have also to add the "auto-generated" text, as the build will just use
the existing NOTICE, if found, without modifying it. You could put something
like the following in the top level NOTICE:
Apache jclouds labs
Copyright 2009-2014 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
The VMWare vSphere API includes sowtware developed at
Cisco Systems, Inc
I've also seen that you've been committing fixes and cleanups to the pull
request. Do you think it will be ready for the review once the NOTICE change
has been addressed?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/61#issuecomment-46413035
