@zack-shoylev thanks. Doesn't look like that's currently enforced on 
jclouds-examples.

Checkstyle violations (based on the checkstyle command on the coding standards 
page):

| branch | violations |
|----------|--------------|
| master | 2446 |
| this PR | 1923 |
| after running [mvn 
java-formatter:format](http://maven-java-formatter-plugin.googlecode.com/svn/site/0.4/usage.html)
 | 6878 :sob: |
after running it with the jclouds eclipse-code-formatter.xml | 1856 |

Of those, there are 160 for "Line has trailing spaces", which is what I was 
trying to remove in the first place, so there is a conflicting 
checkstyle/eclipse rule. If you format and than remove trailing whitespace, its 
down to 1696.

It obviously might not make sense to enforce all the same checkstyle rules on 
jclouds-examples, especially rules related to javadoc. But it looks like its at 
least a step in the right direction.

Here's the top remaining violations, in case you're curious:
```
  505  Line is longer than 80 characters .
 372  Missing a Javadoc comment.
 128  Expected @throws tag for 'IOException'.
  67  Parameter args should be final.
  64 magic number.
  63  Expected @param tag for 'args'.
  62  Method 'close' is not designed for extension - needs to be abstract, 
final or empty.
  60  Parameter username should be final.
  60  Parameter apiKey should be final.
  57  First sentence should end with a period.
  34  Redundant 'public' modifier.
  33  Using the '.*' form of import should be avoided
  12  Redundant 'final' modifier.
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/54#issuecomment-47175857

Reply via email to