> + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, software > + * distributed under the License is distributed on an "AS IS" BASIS, > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > + * See the License for the specific language governing permissions and > + * limitations under the License. > + */ > +package org.jclouds.openstack.swift.blobstore.strategy.internal; > + > +public class MultipartNamingStrategy { > + > + private static final String PART_SEPARATOR = "/"; > + > + protected String getPartName(String key, int partNumber, int totalParts) > { > + int base = (int)Math.log10(totalParts) + 1;
Do we need this complexity? We can name parts with a fixed 8 character width base as in the Swift examples. This should allow 10 million parts and even with the minimum 1 MB part size this allows 100 TB objects. Trying to pick the minimum base also precludes streaming large objects where the caller does not know the final object size. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/427/files#r14438613
