Overall, nice work! A couple of comments:

* In the domain objects, we have many nullable fields. Sometimes they're 
`@Nullable` in the constructor, usually not. Either way works for me, but we 
should try to be consistent both in this PR and with jclouds usage elsewhere?
* In some domain objects, we do empty-collection-to-null conversion, in others 
it's the other way around. Again, be consistent in this PR and with the rest of 
jclouds, if possible?
* Expect tests rather than MockWebServer tests?
* Use builders in the tests?

Thanks, @hsbhathiya and @mattstep!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/31#issuecomment-47975001

Reply via email to