> @@ -68,41 +71,83 @@ public 
> AllocateAndAddFloatingIpToNode(@Named(TIMEOUT_NODE_RUNNING) Predicate<Ato
>     }
>  
>     @Override
> -   public AtomicReference<NodeMetadata> apply(AtomicReference<NodeMetadata> 
> input) {
> -      checkState(nodeRunning.apply(input), "node never achieved state 
> running %s", input.get());
> -      NodeMetadata node = input.get();
> +   public AtomicReference<NodeMetadata> 
> apply(AtomicReference<NodeAndNovaTemplateOptions> input) {
> +      checkState(nodeRunning.apply(input.get().getNodeMetadata()), "node 
> never achieved state running %s", input.get().getNodeMetadata());
> +      NodeMetadata node = input.get().getNodeMetadata().get();

I think `NodeAndNovaTemplateOptions` may be missing, but is there any reason it 
takes two AtomicRefs, rather than simply a Node and a NovaTemplateOptions 
object? I think having the NodeAndNovaTemplateOptions object in an AtomicRef 
should be enough?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/425/files#r14536682

Reply via email to