@demobox looking over things I'm actually going to argue FOR keeping the AtomicReferences inside NodeAndNovaTemplateOptions. The reason being is that we are constantly passing around AtomicReference<NodeMetadata> and so it makes things immensely easier to retrieve it rather than constantly unpacking/packing it back up again. Mainly the classes:
AllocateAndAddFloatingIpToNode ApplyNovaTemplateOptionsCreateNodesWithGroupEncodedIntoNameThenAddToSet currently these are the only 2 classes using this data-structure but they both heavily use AtomicReference<NodeMetadata> and so packing/unpacking would turn the code ugly. IMO this is a reasonable tradeoff. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/425#issuecomment-47985531
