> + * corresponding NovaTemplateOptions object.
> + */
> +public class NodeAndNovaTemplateOptions {
> +
> + private final AtomicReference<NodeMetadata> nodeMetadata;
> + private final AtomicReference<NovaTemplateOptions> novaTemplateOptions;
> +
> + public NodeAndNovaTemplateOptions(NodeMetadata nodeMetadata,
> NovaTemplateOptions novaTemplateOptions){
> + this.nodeMetadata = Atomics.newReference(nodeMetadata);
> + this.novaTemplateOptions = Atomics.newReference(novaTemplateOptions);
> + }
> +
> + public NodeAndNovaTemplateOptions(AtomicReference<NodeMetadata>
> nodeMetadata, AtomicReference<NovaTemplateOptions> novaTemplateOptions){
> + this.nodeMetadata = nodeMetadata;
> + this.novaTemplateOptions = novaTemplateOptions;
> + }
[minor] Are we ever going to create these directly, rather than with the static
helpers? Can we reduce this to one private or protected constructor, and two
static builders
```
public static NodeAndNovaTemplateOptions
newNodeAndNovaTemplateOptions(AtomicReference<NodeMetadata> node,
AtomicReference<NovaTemplateOptions> options) {
return new NodeAndNovaTemplateOptions(node, options);
}
public static NodeAndNovaTemplateOptions
newNodeAndNovaTemplateOptions(NodeMetadata node, NovaTemplateOptions options) {
return newNodeAndNovaTemplateOptions(Atomics.newReference(node),
Atomics.newReference(options));
// or return new NodeAndNovaTemplateOptions(Atomics.newReference(node),
Atomics.newReference(options));
// if we prefer that
}
```
?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/425/files#r14624518
