Hi, @nacx !
So, just to explain my thoughts:
- Yes, in fact, when the method is called using an {code} ExecutorService
{code} internally this executor is decorated using a {code} listeningDecorator
{code}. I will remove these methods.
- In my opinion, the code is better divided in a base class. I don't like the
ideia of duplicate code, even if the code is not so long. Although strategies
represents a concrete behavior, it is represented using interfaces, so the base
class is completely hided by these interfaces, to customize the behavior it is
just necessary extend the strategy implementation class or just implement the
interface. So, for me, the "base" class is just a way to avoid duplicated code,
it doesn't disturbs the logic and the concepts involved on it.
Regards
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/47#issuecomment-49043735
