> @@ -107,6 +107,15 @@ public void testIso8601DateParseTz() {
>     }
>  
>     @Test
> +   public void testIso8601OptionalTZDateParse() {
> +      Date dsDate = dateService
> +            
> .iso8601DateParseWithOptionalTZ(testData[0].iso8601SecondsDateString);
> +      Date secondsDate = dateService
> +            .iso8601SecondsDateParse(testData[0].iso8601SecondsDateString);
> +      assertEquals(dsDate, secondsDate);

Shouldn't this rather test that the new method can parse both 
`testData[0].iso8601DateString` **and** `testData[0].iso8601SecondsDateString` 
and, that if an invalid string is passed, it throws the *first* exception?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/456/files#r15460021

Reply via email to