https://issues.apache.org/jira/browse/JCLOUDS-678
Write operations should not use the `NullOnNotFoundOr404`, as the resource should exist. I've kept that fallback, however, in all the DELETE operations, as it is a pattern widely used in jclouds. If the resource to be deleted does not exist, don't fail, as the *expected result* of the operation is achieved. I've also added the missing unit and live tests for the `InstanceApi.setTags` method. @aledsage could you kindly run the live tests for this change? I don't have an account to use for testing this with right now. You can merge this Pull Request by running: git pull https://github.com/nacx/jclouds-labs-google 678-npe-gce Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/40 -- Commit Summary -- * JCLOUDS-678: Do not silently return null in POST operations -- File Changes -- M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/DiskApi.java (4) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/InstanceApi.java (12) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiExpectTest.java (4) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiExpectTest.java (57) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiLiveTest.java (15) A google-compute-engine/src/test/resources/instance_set_tags.json (4) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/40.patch https://github.com/jclouds/jclouds-labs-google/pull/40.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/40
