> +    * This API is an extension that may or may not be present in your 
> OpenStack cloud. Use the Optional return type
> +    * to determine if it is present.
> +    */
> +   @Delegate
> +   Optional<SecurityGroupApi> getSecurityGroupApi(@EndpointParam(parser = 
> RegionToEndpoint.class) String region);
> +
> +   /**
> +    * Provides access to SecurityGroupRule features.
> +    *
> +    * <h3>NOTE</h3>
> +    * This API is an extension that may or may not be present in your 
> OpenStack cloud. Use the Optional return type
> +    * to determine if it is present.
> +    */
> +   @Delegate
> +   Optional<SecurityGroupRuleApi> getSecurityGroupRuleApi(
> +         @EndpointParam(parser = RegionToEndpoint.class) String region);

I see you split this out into SecurityGroupApi and SecurityGroupRuleApi. These 
logically belong together. What do you think about merging SecurityGroupRuleApi 
into SecurityGroupApi and the domain object SecurityGroupRule just becomes Rule?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/132/files#r16616695

Reply via email to