>  
> +            assertTrue(foundIt, "Failed to find the attachment we set in 
> listAttachments() response");
> +
> +            
> volumeAttachmentApi.get().detachVolumeFromServer(testVolume.getId(), 
> serverId);

Not sure I agree with that. For me this is clearer as it tests the whole 
fea/prevents us from having to preserve info about the server between the tests 
and I think that the stack trace should be enough to indicate where the problem 
is. The other tests here require volume detachment as well.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/326/files#r16750604

Reply via email to