> + }
> +
> + @Override
> + public boolean equals(Object obj) {
> + if (this == obj)
> + return true;
> + if (obj == null || getClass() != obj.getClass())
> + return false;
> + InterfaceAttachment that = InterfaceAttachment.class.cast(obj);
> + return Objects.equal(this.networkId, that.networkId) &&
> Objects.equal(this.portId, that.portId)
> + && Objects.equal(this.portState, that.portState) &&
> Objects.equal(this.macAddress, that.macAddress)
> + && Objects.equal(this.fixedIps, that.fixedIps);
> + }
> +
> + protected Objects.ToStringHelper string() {
> + return Objects.toStringHelper("").omitNullValues().add("network_id",
> networkId).add("port_id", portId)
This came up in another PR I just commented on this week. Since we really want
to know what fields are null, we should resist using `omitNullValues()`! Also,
please change the case of the fields from snakey case to lower Camel case as
they are defined in the class. `network_id` -> `networkId`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/497/files#r16916001
