[ 
https://issues.apache.org/jira/browse/JCLOUDS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118263#comment-14118263
 ] 

Everett Toews commented on JCLOUDS-687:
---------------------------------------

Before starting coding on this, we need to ask some questions and consider 
whether or not it's a good idea. Something very similar also came up during 
development for support of OpenStack Marconi. Please familiarize yourself with 
[this comment 
thread|https://github.com/jclouds/jclouds-labs-openstack/pull/46#issuecomment-27277902].

Some questions:

1. The description itself says "page sizes differ between APIs" so how does 
only two new constants address this for all APIs? Don't you need constants for 
each API?
1. What are the initial values for "PROPERTY_PAGE_SIZE" or 
"PROPERTY_DEFAULT_PAGE_SIZE"? Whatever the initial values, they are going to be 
wrong most of the time because they will vary from service to service and 
deployment to deployment.
1. How are the proper values for "PROPERTY_PAGE_SIZE" or 
"PROPERTY_DEFAULT_PAGE_SIZE" set? 
1. Why are we duplicating service side logic (that will vary from service to 
service and deployment to deployment) in the clients?

[~nacx] and [~andrewp] may have more questions and more to say on this approach 
too.

> Configurable API/Provider Default Page Size
> -------------------------------------------
>
>                 Key: JCLOUDS-687
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-687
>             Project: jclouds
>          Issue Type: Improvement
>          Components: jclouds-core
>    Affects Versions: 1.6.0, 1.7.0, 1.8.0
>            Reporter: Jeremy Daggett
>            Assignee: Jeremy Daggett
>            Priority: Minor
>              Labels: jclouds, openstack
>             Fix For: 2.0.0
>
>
> Each OpenStack API has a default page size that can be returned by the 
> service. The page sizes differ between APIs and there should be a way to 
> reflect this in API/provider configuration. The page size is typically used 
> in the list/get related operations.
> The opportunity arises to expand this to all APIs that have a default page 
> size by introducing a new constant "PROPERTY_PAGE_SIZE" or 
> "PROPERTY_DEFAULT_PAGE_SIZE" to the {{org.jclouds.Constants}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to