> @@ -545,7 +541,9 @@ public void testOverwriteBlobMetadata() throws Exception {
> storageStrategy.putBlob(CONTAINER_NAME, blob);
>
> blob = storageStrategy.getBlob(CONTAINER_NAME, blobKey);
> - assertEquals(blob.getMetadata().getUserMetadata().get("key1"),
> "value1");
> + if (!blob.getMetadata().getUserMetadata().containsKey("key1")) {
> + throw new SkipException("Underlying filesystem does not support
> xattr");
> + }
I'm fine with doing this here, but would it be "more correct" _not_ to do this
in a setup for a specific test, but to have a
`TestUtils.filesystemSupportsXattr()` method that would carry out this check
outside of the scope of any test?
Then the `SkipException` could still happen _at the beginning_ of the test,
which is where it seems it should go..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/510/files#r17203937
