The machine types don't seem to be giving a value for imageSpaceGb.

It is not clear if this missing imageSpaceGb is just for my requests to the api 
or if 
this is happening to all users of the API. I have filed a bug with google to 
clarify 

https://code.google.com/p/google-compute-engine/issues/detail?id=111

In the mean time I am assuming that this is the case and the imageSpaceGb will 
no longer appear in the response. 

The missing imageSpaceGb means they get the value zero in MachineType 
and as a consequence the Hardware does not support an image and the simple 
`computeService.templateBuilder().smallest().build()`
fails to find a valid template.

However, google's documentation states that 'You must always specify an
image when you create an instance...'.

So it would seem sensible that the missing value for this is ignored and
supportsImage uses the alwaysTrue predicate.

You can merge this Pull Request by running:

  git pull https://github.com/stuarthendren/jclouds-labs-google dev

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/49

-- Commit Summary --

  * JCLOUDS-703 missing imageSpaceGb from machineType
  * JCLOUDS-703 removing imageSpaceGb from machineType

-- File Changes --

    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/functions/MachineTypeInZoneToHardware.java
 (6)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/MachineType.java
 (20)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceExpectTest.java
 (2)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java
 (3)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeTest.java
 (1)
    M google-compute-engine/src/test/resources/machinetype.json (1)
    M google-compute-engine/src/test/resources/machinetype_list.json (3)
    M google-compute-engine/src/test/resources/machinetype_list_central1b.json 
(2)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/49.patch
https://github.com/jclouds/jclouds-labs-google/pull/49.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/49

Reply via email to