@fbrouille Thanks for this PR! Overall it looks very good to me. I have a few 
comments, but they all seem pretty minor.
It would also be nice if we can add some more docs to some of these enums and 
getters and builder setters for users.

Some notes on structure and style differences: most of these seem like 
improvements to me, and we might have to apply them to the rest of the neutron 
code (in a different PR).
I do like that the new stuff is in its own lbaas/v1 directories (esp the domain 
classes, something we should consider doing). However, this is probably not 
needed under /extensions - just keep LBaaSApi on the same directory level as 
say RouterApi. I am not so sure if we should do the same for the fallbacks and 
functions or not: thoughts?



---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/146#issuecomment-56415849

Reply via email to