> @@ -179,6 +179,8 @@ public NovaTemplateOptions keyPairName(String 
> keyPairName) {
>      */
>     @Deprecated
>     public NovaTemplateOptions securityGroupNames(String... 
> securityGroupNames) {
> +      for (String groupName : checkNotNull(securityGroupNames, 
> "securityGroupNames"))
> +         checkNotNull(emptyToNull(groupName), "all security groups must be 
> non-empty");

As @jdaggett said: please add `{ ... }`. Also:

* why are **empty** group names not allowed?
* we can remove the `checkNotNull` in the next line

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/515/files#r17993484

Reply via email to