Dear all, first of all, thanks for your review everybody! I have changed the PR to fix some issues you have pointed. Before merge, I think there is still some points to clarify: - Version in method name: Because in future, 2 versions of LBaaS API will coexist (v1 and v2), I simply decided to put the version in method name (without thinking too much): <code>NeutronApi.getLBaaSv1Api</code> (and <code>NeutronApi.getLBaaSv2Api</code> in another future PR for LBaaS v2). If the rule for extension APIs is to use the alias name in the method signature, I have to rename the method to <code>NeutronApi.getLBaaSApi</code> (and the method name for v2 will be <code>NeutronApi.getLBaaSv2Api</code>), as @jdaggett has suggested it. Let me know if I have to remove the version in method name. - Version in packages: For the same reason, I simply decide to put all classes about LBaaS in a 'v1' packages (domain, extensions, fallbacks, functions). I thought this was the simplest solution to prepare future integration of LBaaS v2. However, it seems more and more unlikely that LBaaS v2 will be part of the next release of OpenStack (Juno due date is october 16 and LBaaS improvements have not yet been reviewed). So maybe it is to early to talk about LBaaS v2 and maybe it is preferable to simply ignore it and remove version in package names and in classnames. What do you think?
--- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-openstack/pull/146#issuecomment-56814435
