Re: [jclouds-labs] [JCLOUDS-702] JCloud ProfitBricks provider implementation (#72)

[Reijhanniel Jearl Campos]

> +   private String generateRequestPayload(AddFirewallRulesToNic rules) {
> +      requestBuilder.setLength(0);
> +      requestBuilder.append("<ws:addFirewallRulesToNic>");
> +      for (FirewallRuleRequest rule : rules.getRequest())
> +         requestBuilder.append("<request>")
> +                 .append(ifNotEmpty("<icmpCode>%s</icmpCode>", 
> rule.getIcmpCode()))
> +                 .append(ifNotEmpty("<icmpType>%s</icmpType>", 
> rule.getIcmpType()))
> +                 .append(ifNotEmpty("<name>%s</name>", rule.getName()))
> +                 .append(ifNotEmpty("<portRangeEnd>%s</portRangeEnd>", 
> rule.getPortRangeEnd()))
> +                 .append(ifNotEmpty("<portRangeStart>%s</portRangeStart>", 
> rule.getPortRangeStart()))
> +                 .append(ifNotEmpty("<protocol>%s</protocol>", 
> rule.getProtocol()))
> +                 .append(ifNotEmpty("<sourceIp>%s</sourceIp>", 
> rule.getSourceIp()))
> +                 .append(ifNotEmpty("<sourceMac>%s</sourceMac>", 
> rule.getSourceMac()))
> +                 .append(ifNotEmpty("<targetIp>%s</targetIp>", 
> rule.getTargetIp()))
> +                 .append("</request>");
> +      requestBuilder.append(rightAway("<nicId>%s</nicId>", 
> checkNotNull(rules.getNicId())))

Hmm, not sure I get that. Do you mean align line 54 with line 43?
<pre>
for(FirewallRuleRequest rule...)
   requestBuilder.append("<request>")
               .append(...
               ...
   requestBuilder.append(...    &lt;- Like this?
</pre>

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/72/files#r18070080