This cleans up the azure management api so that we can start working on it again. This doesn't mean cleanups are done. this is just the first stab.
It does the following. * removes async stuff * move off deprecated core code (ex RestApiModule) * fixes random annotation problems * fix a ton of checkstyle issues * rewrite the expect tests as mock tests * remove the directory trees of unused model classes. * minimally reworks existing domain objects so that they pass checkstyle etc. * clear up naming around image In all, this removes over 3k lines of debt. After this, we can start clearing up the api interfaces, updating to any changes in the azure api since written, think about compute service integration. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs adrian.cleanup-azure-management Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/76 -- Commit Summary -- * JCLOUDS-664 Removed dead code and refactored good code. -- File Changes -- M azure-management/pom.xml (57) M azure-management/src/main/java/org/jclouds/azure/management/AzureManagementApi.java (51) M azure-management/src/main/java/org/jclouds/azure/management/AzureManagementApiMetadata.java (40) D azure-management/src/main/java/org/jclouds/azure/management/AzureManagementAsyncApi.java (94) M azure-management/src/main/java/org/jclouds/azure/management/AzureManagementProviderMetadata.java (8) M azure-management/src/main/java/org/jclouds/azure/management/binders/BindCreateHostedServiceToXmlPayload.java (15) M azure-management/src/main/java/org/jclouds/azure/management/binders/BindDeploymentParamsToXmlPayload.java (173) M azure-management/src/main/java/org/jclouds/azure/management/binders/BindOSImageParamsToXmlPayload.java (10) M azure-management/src/main/java/org/jclouds/azure/management/compute/AzureManagementComputeServiceAdapter.java (171) M azure-management/src/main/java/org/jclouds/azure/management/compute/config/AzureManagementComputeServiceContextModule.java (16) M azure-management/src/main/java/org/jclouds/azure/management/compute/functions/DeploymentToNodeMetadata.java (3) M azure-management/src/main/java/org/jclouds/azure/management/compute/functions/OSImageToImage.java (8) M azure-management/src/main/java/org/jclouds/azure/management/compute/functions/RoleSizeToHardware.java (3) R azure-management/src/main/java/org/jclouds/azure/management/config/AzureManagementHttpApiModule.java (24) M azure-management/src/main/java/org/jclouds/azure/management/config/AzureManagementProperties.java (6) D azure-management/src/main/java/org/jclouds/azure/management/config/AzureManagementRestClientModule.java (75) M azure-management/src/main/java/org/jclouds/azure/management/domain/Deployment.java (569) M azure-management/src/main/java/org/jclouds/azure/management/domain/DeploymentParams.java (370) M azure-management/src/main/java/org/jclouds/azure/management/domain/DeploymentSlot.java (35) M azure-management/src/main/java/org/jclouds/azure/management/domain/DeploymentStatus.java (4) M azure-management/src/main/java/org/jclouds/azure/management/domain/DetailedHostedServiceProperties.java (81) M azure-management/src/main/java/org/jclouds/azure/management/domain/Disk.java (207) M azure-management/src/main/java/org/jclouds/azure/management/domain/Error.java (40) M azure-management/src/main/java/org/jclouds/azure/management/domain/HostedService.java (21) M azure-management/src/main/java/org/jclouds/azure/management/domain/HostedServiceProperties.java (16) M azure-management/src/main/java/org/jclouds/azure/management/domain/HostedServiceWithDetailedProperties.java (26) R azure-management/src/main/java/org/jclouds/azure/management/domain/Image.java (163) R azure-management/src/main/java/org/jclouds/azure/management/domain/ImageParams.java (66) M azure-management/src/main/java/org/jclouds/azure/management/domain/InputEndpoint.java (4) M azure-management/src/main/java/org/jclouds/azure/management/domain/InstanceStatus.java (6) M azure-management/src/main/java/org/jclouds/azure/management/domain/Location.java (29) M azure-management/src/main/java/org/jclouds/azure/management/domain/OSType.java (4) M azure-management/src/main/java/org/jclouds/azure/management/domain/Operation.java (18) R azure-management/src/main/java/org/jclouds/azure/management/domain/Protocol.java (14) M azure-management/src/main/java/org/jclouds/azure/management/domain/RoleSize.java (35) D azure-management/src/main/java/org/jclouds/azure/management/domain/hostedservice/CreateDeployment.java (214) D azure-management/src/main/java/org/jclouds/azure/management/domain/hostedservice/ExtendedProperty.java (102) D azure-management/src/main/java/org/jclouds/azure/management/domain/hostedservice/package-info.java (24) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/AbstractRole.java (143) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/DNS.java (78) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/DNSServer.java (93) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/DataVirtualHardDisk.java (57) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/Deployment.java (185) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/HostCaching.java (29) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/OSVirtualHardDisk.java (66) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/PersistentVMRole.java (24) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/Role.java (24) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/RoleSize.java (36) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/VirtualHardDisk.java (88) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/CertificateSetting.java (78) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/ConfigurationSet.java (47) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/ConfigurationSetAdapter.java (150) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/Credentials.java (75) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/DomainJoin.java (78) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/InputEndpoint.java (141) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/KeyPair.java (32) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/LinuxProvisioningConfiguration.java (105) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/LoadBalancerProbe.java (81) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/NetworkConfiguration.java (68) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/PublicKey.java (32) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/SSH.java (67) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/SSHKey.java (55) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/WindowsProvisioningConfiguration.java (140) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/package-info.java (25) D azure-management/src/main/java/org/jclouds/azure/management/domain/role/package-info.java (25) M azure-management/src/main/java/org/jclouds/azure/management/features/DiskApi.java (40) D azure-management/src/main/java/org/jclouds/azure/management/features/DiskAsyncApi.java (71) M azure-management/src/main/java/org/jclouds/azure/management/features/HostedServiceApi.java (137) D azure-management/src/main/java/org/jclouds/azure/management/features/HostedServiceAsyncApi.java (155) R azure-management/src/main/java/org/jclouds/azure/management/features/ImageApi.java (67) M azure-management/src/main/java/org/jclouds/azure/management/features/LocationApi.java (27) D azure-management/src/main/java/org/jclouds/azure/management/features/LocationAsyncApi.java (58) D azure-management/src/main/java/org/jclouds/azure/management/features/OSImageApi.java (63) M azure-management/src/main/java/org/jclouds/azure/management/features/OperationApi.java (25) D azure-management/src/main/java/org/jclouds/azure/management/features/OperationAsyncApi.java (55) M azure-management/src/main/java/org/jclouds/azure/management/features/RoleApi.java (87) D azure-management/src/main/java/org/jclouds/azure/management/features/RoleAsyncApi.java (137) M azure-management/src/main/java/org/jclouds/azure/management/functions/OSImageParamsName.java (15) M azure-management/src/main/java/org/jclouds/azure/management/functions/ParseRequestIdHeader.java (8) M azure-management/src/main/java/org/jclouds/azure/management/options/CreateHostedServiceOptions.java (26) M azure-management/src/main/java/org/jclouds/azure/management/suppliers/KeyStoreSupplier.java (14) M azure-management/src/main/java/org/jclouds/azure/management/suppliers/SSLContextWithKeysSupplier.java (9) M azure-management/src/main/java/org/jclouds/azure/management/xml/AttachmentHandler.java (9) M azure-management/src/main/java/org/jclouds/azure/management/xml/DeploymentHandler.java (163) M azure-management/src/main/java/org/jclouds/azure/management/xml/DetailedHostedServicePropertiesHandler.java (20) M azure-management/src/main/java/org/jclouds/azure/management/xml/DiskHandler.java (28) M azure-management/src/main/java/org/jclouds/azure/management/xml/ErrorHandler.java (10) M azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceHandler.java (30) M azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServicePropertiesHandler.java (18) M azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceWithDetailedPropertiesHandler.java (6) R azure-management/src/main/java/org/jclouds/azure/management/xml/ImageHandler.java (29) M azure-management/src/main/java/org/jclouds/azure/management/xml/ListDisksHandler.java (29) M azure-management/src/main/java/org/jclouds/azure/management/xml/ListHostedServicesHandler.java (29) R azure-management/src/main/java/org/jclouds/azure/management/xml/ListImagesHandler.java (35) M azure-management/src/main/java/org/jclouds/azure/management/xml/ListLocationsHandler.java (29) M azure-management/src/main/java/org/jclouds/azure/management/xml/LocationHandler.java (10) M azure-management/src/main/java/org/jclouds/azure/management/xml/OperationHandler.java (32) D azure-management/src/test/java/org/jclouds/azure/management/features/DiskApiExpectTest.java (81) M azure-management/src/test/java/org/jclouds/azure/management/features/DiskApiLiveTest.java (38) A azure-management/src/test/java/org/jclouds/azure/management/features/DiskApiMockTest.java (88) D azure-management/src/test/java/org/jclouds/azure/management/features/HostedServiceApiExpectTest.java (168) M azure-management/src/test/java/org/jclouds/azure/management/features/HostedServiceApiLiveTest.java (43) A azure-management/src/test/java/org/jclouds/azure/management/features/HostedServiceApiMockTest.java (185) R azure-management/src/test/java/org/jclouds/azure/management/features/ImageApiLiveTest.java (41) A azure-management/src/test/java/org/jclouds/azure/management/features/ImageApiMockTest.java (127) D azure-management/src/test/java/org/jclouds/azure/management/features/LocationApiExpectTest.java (59) M azure-management/src/test/java/org/jclouds/azure/management/features/LocationApiLiveTest.java (28) A azure-management/src/test/java/org/jclouds/azure/management/features/LocationApiMockTest.java (58) D azure-management/src/test/java/org/jclouds/azure/management/features/OSImageApiExpectTest.java (115) D azure-management/src/test/java/org/jclouds/azure/management/features/OperationApiExpectTest.java (55) A azure-management/src/test/java/org/jclouds/azure/management/features/OperationApiMockTest.java (59) D azure-management/src/test/java/org/jclouds/azure/management/features/RoleApiExpectTest.java (173) A azure-management/src/test/java/org/jclouds/azure/management/features/RoleApiMockTest.java (119) M azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementApiLiveTest.java (28) A azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementApiMockTest.java (95) D azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementAsyncApiExpectTest.java (32) D azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementExpectTest.java (55) M azure-management/src/test/java/org/jclouds/azure/management/parse/ErrorTest.java (6) M azure-management/src/test/java/org/jclouds/azure/management/parse/GetDeploymentTest.java (7) M azure-management/src/test/java/org/jclouds/azure/management/parse/GetHostedServiceDetailsTest.java (10) M azure-management/src/test/java/org/jclouds/azure/management/parse/GetHostedServiceTest.java (8) M azure-management/src/test/java/org/jclouds/azure/management/parse/GetOperationTest.java (9) M azure-management/src/test/java/org/jclouds/azure/management/parse/ListDisksTest.java (12) M azure-management/src/test/java/org/jclouds/azure/management/parse/ListHostedServicesTest.java (17) R azure-management/src/test/java/org/jclouds/azure/management/parse/ListImagesTest.java (41) M azure-management/src/test/java/org/jclouds/azure/management/parse/ListLocationsTest.java (19) M azure-management/src/test/resources/disks.xml (2) M azure-management/src/test/resources/images.xml (2) M azure-management/src/test/resources/locations.xml (2) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/76.patch https://github.com/jclouds/jclouds-labs/pull/76.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/76
