general commentary.

I wouldn't want to use this api. It is laden with danger as everything is 
marked nullable, even booleans.

If in the last couple years we've gotten away from making null-safe objects, 
forgive the late commentary, but yeah, this codebase is a NPE waiting to 
happen, and I'd have no idea which fields can be relied on at all.

I'd suggest we start decrufting with google auto value as well, since many 
things here are laborious boilerplates. Moreover, in many cases builders are 
only used in tests. Using tools like assertj, we should be able to guarantee 
tests without builders. If there's no non-internal use case for constructing an 
object, we should probably spare the pain of writing builders everywhere.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/146#issuecomment-57659517

Reply via email to