The extra fields on ListPage were causing NPEs as they were expected present. 
There's no value in id, selfLink on a list anyway.

While working on this, I noticed we were backing an Iterable with a Set. It is 
cheaper to do this with a List, so I switched it.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs-google adrian.JCLOUDS-740

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/50

-- Commit Summary --

  * JCLOUDS-740 GCE doesn't always return id, selfLink on lists. Also, 
internally buffering an Iterable with a Set < with a List.

-- File Changes --

    M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListPage.java
 (5)
    M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclListTest.java
 (5)
    M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectAclListTest.java
 (4)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/ListPage.java
 (72)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/RegionOperationApiExpectTest.java
 (4)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java
 (2)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseAddressListTest.java
 (10)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskListTest.java
 (8)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallListTest.java
 (12)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageListTest.java
 (10)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java
 (8)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java
 (3)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseNetworkListTest.java
 (9)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseOperationListTest.java
 (4)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRegionListTest.java
 (51)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseRouteListTest.java
 (6)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseSnapshotListTest.java
 (33)
    M 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneListTest.java
 (47)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/50.patch
https://github.com/jclouds/jclouds-labs-google/pull/50.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/50

Reply via email to