I figured before adding support for SSDs it makes sense to add coverage of the 
DiskTypes Api. 

DiskTypes Api Documentation: 
https://cloud.google.com/compute/docs/reference/latest/diskTypes 

The implementation is very similar to MachineTypes Api. Refactoring 
redundancies may be desirable in the future. 

Also like MachineTypes this only covers the "get" and 
"list" operations and does not yet cover the 
"aggregatedList" operation.  

 
You can merge this Pull Request by running:

  git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google ssd

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/56

-- Commit Summary --

  * Added support for DiskTypes Api. Missing Testing
  * Merge branch 'master' of 
https://github.com/GoogleCloudPlatform/jclouds-labs-google into ssd
  * Adding missing files
  * Added testing for DiskType Api coverage
  * fixing indentation and replacing tabs with spaces
  * added newlines at end of some files

-- File Changes --

    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApi.java
 (10)
    A 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/DiskType.java
 (165)
    M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Resource.java
 (2)
    A 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/DiskTypeApi.java
 (142)
    A 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/functions/internal/ParseDiskTypes.java
 (64)
    A 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskTypeApiExpectTest.java
 (113)
    A 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskTypeApiLiveTest.java
 (73)
    A 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTypeListTest.java
 (64)
    A 
google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTypeTest.java
 (50)
    A google-compute-engine/src/test/resources/disktype.json (11)
    A google-compute-engine/src/test/resources/disktype_list.json (27)
    A google-compute-engine/src/test/resources/disktype_list_central1b.json (17)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-google/pull/56.patch
https://github.com/jclouds/jclouds-labs-google/pull/56.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/56

Reply via email to