> @@ -173,6 +173,54 @@ public void testRemoveIpPermission() {
>     }
>  
>     @Test(groups = { "integration", "live" }, singleThreaded = true, 
> dependsOnMethods = "testRemoveIpPermission")
> +   public void testAddIpPermissionWithCidrExclusionGroup() {
> +      skipIfSecurityGroupsNotSupported();
> +
> +      ComputeService computeService = view.getComputeService();
> +
> +      Optional<SecurityGroupExtension> securityGroupExtension = 
> computeService.getSecurityGroupExtension();
> +      assertTrue(securityGroupExtension.isPresent(), "security group 
> extension was not present");

I'm not sure why this is configured this way, but the skip method reads [this 
variable](https://github.com/jclouds/jclouds/blob/master/compute/src/test/java/org/jclouds/compute/extensions/internal/BaseSecurityGroupExtensionLiveTest.java#L67),
 which is not set by checking the presence of the extension. Seems like 
something that can be rethought and refactored in an upcoming PR.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/567/files#r18749900

Reply via email to