> +
> + @ConstructorProperties({
> + "id", "creationTimestamp", "selfLink", "name", "description",
> "validDiskSize",
> + "deprecated", "zone", "defaultDiskSizeGb"
> + })
> + private DiskType(String id, Date creationTimestamp, URI selfLink, String
> name, String description,
> + String validDiskSize, Deprecated deprecated, String zone,
> long defaultDiskSizeGb){
> + super(Kind.DISK_TYPE, id == null ? "" : id, creationTimestamp,
> selfLink, name, description);
> + this.validDiskSize = checkNotNull(validDiskSize, "validDiskSize of
> %s", name);
> + this.deprecated = fromNullable(deprecated);
> + this.zone = checkNotNull(zone, "zone of %s", name);
> + this.defaultDiskSizeGb = defaultDiskSizeGb;
> + }
> +
> + /**
> + * @return An optional textual description of the valid disk size. For
> example, "10GB-10TB."
I'd change it to return an `Optional`, for consistency with the `deprecated`
field, and for the implicit benefits of using Optional vs null.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/56/files#r19083132
