DeploymentParams oddly had a name member, which made it senseless to use as a template ("knowing name is unique"). This sorts that out and also cleans up the input value type, retaining the Builder until we figure something better to do about that.
This also nests OSType into Image as looking at the docs, that's the canonical place for it. The combination of these two changes leave the top-level namespace of the domain objects in pretty good shape. That said, a follow-up PR will clean up ImageParams as that requires some thinking. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs adrian.azurecompute-input-cleanup Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/94 -- Commit Summary -- * Cleanup Azure compute DeploymentParams input value type. * Azure's OSType is reliable so needs no defensive UNRECOGNIZED enum value. Simplify use and couple to Image. -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/binders/BindOSImageParamsToXmlPayload.java (25) R azurecompute/src/main/java/org/jclouds/azurecompute/binders/CreateDeploymentToXML.java (82) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (314) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Disk.java (1) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Image.java (3) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/ImageParams.java (9) D azurecompute/src/main/java/org/jclouds/azurecompute/domain/InputEndpoint.java (137) D azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSType.java (45) D azurecompute/src/main/java/org/jclouds/azurecompute/domain/Protocol.java (23) M azurecompute/src/main/java/org/jclouds/azurecompute/features/DeploymentApi.java (10) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DiskHandler.java (12) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/ImageHandler.java (7) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (19) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DiskApiLiveTest.java (3) M azurecompute/src/test/java/org/jclouds/azurecompute/features/ImageApiLiveTest.java (2) M azurecompute/src/test/java/org/jclouds/azurecompute/features/ImageApiMockTest.java (2) M azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListDisksHandlerTest.java (2) M azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListImagesHandlerTest.java (5) M azurecompute/src/test/resources/deploymentparams.xml (2) M azurecompute/src/test/resources/images.xml (4) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/94.patch https://github.com/jclouds/jclouds-labs/pull/94.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/94
