Epic. So, I'm expecting that there will be some live test impact, I guess (plus 
the mock/expect you mentioned). I'm also assuming you are following convention 
of existing codebase to avoid confusing things by porting only this to whatever 
latest style is.

I must admit that the tags concept is a bit confusing, particularly the array 
of things bit vs the map thing. I'd like to see an in-out live test, at least 
on one resource that explains the relationship between the tags on options and 
the Tag array thing. Otherwise, just explaining could help. I am probably 
fishing for whether it is possible to make tags appear less weird, and hide its 
weirdness inside somehow. Failing that possibility, the general approach looks 
sound.

Thanks for the help!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59876768

Reply via email to