> +import javax.inject.Inject;
> +
> +import org.jclouds.googlecomputeengine.options.DiskCreationOptions;
> +import org.jclouds.http.HttpRequest;
> +import org.jclouds.rest.MapBinder;
> +import org.jclouds.rest.binders.BindToJsonPayload;
> +
> +public class DiskCreationBinder implements MapBinder {
> +
> + @Inject
> + private BindToJsonPayload jsonBinder;
> +
> + public DiskCreationBinder SetBinder(BindToJsonPayload jsonBinder){
> + this.jsonBinder = jsonBinder;
> + return this;
> + }
Instead of having the `jsonBinder` variable and exposing this public method,
would it make sense to directly extend the `BindToJsonPayload` class?
This way we can get rid of this variable and public setter, and we should only
have to implement the method that accepts the `Map<String, Object>`; the other
one could be removed, as the `BindToJsonPayload` already implements it the
right way.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/58/files#r19136914